Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vk: remove duplicate condition in pipeline_props struct equal operator #6042

Merged
merged 2 commits into from May 31, 2019
Merged

vk: remove duplicate condition in pipeline_props struct equal operator #6042

merged 2 commits into from May 31, 2019

Conversation

scribam
Copy link
Contributor

@scribam scribam commented May 31, 2019

I can also replace

if (num_targets != other.num_targets)
	return false;

return num_targets == other.num_targets;

by

if (num_targets != other.num_targets)
	return false;

return true;

if preferred

@AniLeo AniLeo requested a review from kd-11 May 31, 2019 18:32
@Nekotekina Nekotekina merged commit 141d783 into RPCS3:master May 31, 2019
@scribam scribam deleted the vk-duplicate-cond branch May 31, 2019 21:14
@maricelase maricelase mentioned this pull request Nov 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kd-11 kd-11 kd-11 approved these changes

Assignees

@kd-11 kd-11

Labels
Miscellaneous Render: Vulkan
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@scribam @kd-11 @Nekotekina @AniLeo